Cmake Modernization #2722
Closed
Cmake Modernization #2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Teoh <[email protected]>
Signed-off-by: Alex Teoh <[email protected]>
Signed-off-by: Alex Teoh <[email protected]>
Signed-off-by: Alex Teoh <[email protected]>
|
@alexteoh-intel is this ready for review? |
Hi @steven-bellock, thanks it's not yet ready. I'm still testing locally with an outside cmake project and calibrating the changes required. |
|
Closing PR for now. I'm planning propose only a portion of the changes from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to modernize CMake code in this repo. For example, we're moving away from global functions (include_directories) that impact all targets.
Coding style here is based on Effective Modern CMake, which was referred by https://cliutils.gitlab.io/modern-cmake/chapters/intro/dodonot.html.
Other misc changes:
undefined reference tolibspdm_sleep'`