Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move define out of spdm_lib_config #2742

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

steven-bellock
Copy link
Contributor

Fix #2741.

Signed-off-by: Steven Bellock [email protected]

@jyao1
Copy link
Member

jyao1 commented Jul 1, 2024

I think we need consistent way for LIBSPDM_MAX_CERT_CHAIN_SIZE, LIBSPDM_MAX_MEASUREMENT_RECORD_SIZE, LIBSPDM_MAX_MEASUREMENT_EXTENSION_LOG_SIZE.

We can remove LIBSPDM_MAX_CERT_CHAIN_BLOCK_LEN and LIBSPDM_MAX_MEL_BLOCK_LEN.

@steven-bellock
Copy link
Contributor Author

We can remove LIBSPDM_MAX_CERT_CHAIN_BLOCK_LEN and LIBSPDM_MAX_MEL_BLOCK_LEN.

That's covered by #1655, but at this point that's a 4.0 enhancement.

@steven-bellock
Copy link
Contributor Author

This also needs to be #defined in https://github.com/DMTF/spdm-dump/.

@steven-bellock steven-bellock merged commit 74d31e1 into DMTF:main Jul 8, 2024
97 checks passed
@steven-bellock steven-bellock deleted the fix-2741 branch July 8, 2024 14:44
steven-bellock added a commit to steven-bellock/libspdm that referenced this pull request Jul 8, 2024
Follow-on to DMTF#2742.

Signed-off-by: Steven Bellock <[email protected]>
@steven-bellock steven-bellock mentioned this pull request Jul 8, 2024
steven-bellock added a commit that referenced this pull request Jul 8, 2024
Follow-on to #2742.

Signed-off-by: Steven Bellock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move LIBSPDM_MAX_MEASUREMENT_EXTENSION_LOG_SIZE
2 participants