Don't require PSK macros if PSK is not enabled #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If LIBSPDM_ENABLE_CAPABILITY_PSK_EX_CAP is not enabled then LIBSPDM_PSK_CONTEXT_LENGTH and LIBSPDM_PSK_MAX_HINT_LENGTH are still required for a successful build. This pull request fixes that as a subtask of DMTF#1211. Signed-off-by: Steven Bellock <[email protected]>
jyao1
reviewed
Jul 10, 2024
| @@ -7,6 +7,121 @@ | |||
| #ifndef SPDM_LIB_CONFIG_H | |||
| #define SPDM_LIB_CONFIG_H | |||
|
|
|||
| /* Code space optimization for optional messages. | |||
There was a problem hiding this comment.
For #if LIBSPDM_ENABLE_CAPABILITY_PSK_CAP in line 151.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
LIBSPDM_ENABLE_CAPABILITY_PSK_EX_CAPis not enabled thenLIBSPDM_PSK_CONTEXT_LENGTHandLIBSPDM_PSK_MAX_HINT_LENGTHare still required for a successful build. This pull request fixes that as a subtask of #1211.Signed-off-by: Steven Bellock [email protected]