Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): test a11y sur toutes les pages n'ayant pas de problemes d'a11y #1654

Merged
merged 2 commits into from
Jul 27, 2023
Merged

chore(test): test a11y sur toutes les pages n'ayant pas de problemes d'a11y #1654

merged 2 commits into from
Jul 27, 2023

Conversation

Naorid
Copy link
Contributor

@Naorid Naorid commented Jul 19, 2023

No description provided.

@Naorid Naorid temporarily deployed to scalingo-recette July 19, 2023 15:49 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 6fdb171 to da3fa44 Compare July 20, 2023 15:14
@Naorid Naorid temporarily deployed to scalingo-recette July 20, 2023 15:14 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from da3fa44 to 0b6ff8e Compare July 20, 2023 15:14
@Naorid Naorid temporarily deployed to scalingo-recette July 20, 2023 15:14 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 0b6ff8e to e7a2228 Compare July 20, 2023 15:21
@Naorid Naorid temporarily deployed to scalingo-recette July 20, 2023 15:21 — with GitHub Actions Inactive
@Naorid Naorid temporarily deployed to scalingo-recette July 20, 2023 15:21 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from b344135 to bc78714 Compare July 20, 2023 15:24
@Naorid Naorid temporarily deployed to scalingo-recette July 20, 2023 15:24 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from bc78714 to cd75702 Compare July 21, 2023 15:48
@Naorid Naorid temporarily deployed to scalingo-recette July 21, 2023 15:48 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from cd75702 to 7f2f8a9 Compare July 21, 2023 16:42
@Naorid Naorid temporarily deployed to scalingo-recette July 21, 2023 16:42 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 7f2f8a9 to 2bc9e58 Compare July 21, 2023 16:44
@Naorid Naorid temporarily deployed to scalingo-recette July 21, 2023 16:44 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 2bc9e58 to 0f57c23 Compare July 21, 2023 16:44
@Naorid Naorid temporarily deployed to scalingo-recette July 21, 2023 16:44 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 0f57c23 to 489e4b6 Compare July 21, 2023 16:45
@Naorid Naorid temporarily deployed to scalingo-recette July 21, 2023 16:45 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 489e4b6 to f128186 Compare July 21, 2023 16:45
@Naorid Naorid temporarily deployed to scalingo-recette July 21, 2023 16:45 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from f128186 to 5795799 Compare July 21, 2023 16:45
@Naorid Naorid temporarily deployed to scalingo-recette July 21, 2023 16:45 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 5795799 to 3306879 Compare July 21, 2023 16:46
@Naorid Naorid temporarily deployed to scalingo-recette July 21, 2023 16:46 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 3306879 to 81feb26 Compare July 21, 2023 16:46
@Naorid Naorid temporarily deployed to scalingo-recette July 21, 2023 16:46 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 81feb26 to 2fcdc37 Compare July 21, 2023 16:55
@Naorid Naorid temporarily deployed to scalingo-recette July 21, 2023 16:55 — with GitHub Actions Inactive
@Naorid Naorid marked this pull request as ready for review July 21, 2023 17:01
Mintoo200
Mintoo200 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@Mintoo200 Mintoo200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y avait une idée à un moment d'étendre expect plutôt que de faire une fonction checkA11y. On en avait parlé avec @gmoocto, vous en avez parlé ?

src/pages/accessibilite/index.page.test.tsx Outdated Show resolved Hide resolved
src/pages/apprentissage-entreprises/index.page.test.tsx Outdated Show resolved Hide resolved
@Naorid Naorid temporarily deployed to scalingo-recette July 26, 2023 13:28 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 80941c5 to 0106ae6 Compare July 26, 2023 13:40
@Naorid Naorid temporarily deployed to scalingo-recette July 26, 2023 13:40 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 0106ae6 to b517f7a Compare July 26, 2023 13:42
@Naorid Naorid temporarily deployed to scalingo-recette July 26, 2023 13:42 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from b517f7a to 3fa28c0 Compare July 26, 2023 14:22
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from 3fa28c0 to ab77451 Compare July 26, 2023 14:23
@Naorid Naorid temporarily deployed to scalingo-recette July 26, 2023 14:23 — with GitHub Actions Inactive
@Naorid Naorid force-pushed the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch from ab77451 to 48dcac1 Compare July 27, 2023 15:33
@Naorid Naorid temporarily deployed to scalingo-recette July 27, 2023 15:33 — with GitHub Actions Inactive
@Naorid Naorid merged commit 77a417f into main Jul 27, 2023
6 checks passed
@Naorid Naorid deleted the feat/UNJ1S-1594-Ouvrir-des-PR-qui-ajoutent-les-tests-auto-jest-d-a11y-sur-toutes-les-pages branch July 27, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mintoo200 Mintoo200 Mintoo200 approved these changes

Assignees

@Mintoo200 Mintoo200

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naorid @Mintoo200