Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): retour du focus lors de la fermeture de la modale #3149

Merged
merged 1 commit into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions src/client/components/ui/Modal/ModalComponent.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import { render, screen } from '@testing-library/react';
import { userEvent } from '@testing-library/user-event';
import { BaseSyntheticEvent } from 'react';
import { BaseSyntheticEvent, useState } from 'react';

import { KeyBoard } from '~/client/components/keyboard/keyboard.enum';
import { ModalComponent } from '~/client/components/ui/Modal/ModalComponent';
Expand All @@ -15,7 +15,8 @@ describe('ModalComponent', () => {
aria-label="label"
isOpen={true}
closeLabel={'Fermer'}
close={() => {}}
close={() => {
}}
>
<ModalComponent.Title>
Ceci est le titre de la modale
Expand All @@ -28,6 +29,34 @@ describe('ModalComponent', () => {
const boutonFermer = screen.getByRole('button', { name: 'Fermer' });
expect(boutonFermer).toHaveFocus();
});

it('lorsque je ferme la modale, le focus revient sur l‘élément qui avait le focus avant l‘ouverture', async () => {
const user = userEvent.setup();

function ButtonWithModale() {
const [isModaleOpen, setIsModaleOpen] = useState<boolean>(false);
return <>
<button onClick={() => setIsModaleOpen(true)}>Ouvrir la modale</button>
<ModalComponent
aria-label="label"
isOpen={isModaleOpen}
closeLabel={'Fermer'}
close={() => setIsModaleOpen(false)}>
<ModalComponent.Content>Ceci est le contenu de la modale</ModalComponent.Content>
</ModalComponent>
</>;
}

render(<ButtonWithModale/>);

await user.click(screen.getByRole('button', { name: 'Ouvrir la modale' }));
expect(screen.getByRole('button', { name: 'Fermer' })).toHaveFocus();

await user.click(screen.getByRole('button', { name: 'Fermer' }));

expect(screen.getByRole('button', { name: 'Ouvrir la modale' })).toHaveFocus();
});

it('ferme la modale quand on appuie sur Échap', async () => {
const user = userEvent.setup();
const onClose = jest.fn();
Expand Down
13 changes: 9 additions & 4 deletions src/client/components/ui/Modal/ModalComponent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,19 @@ export function ModalComponent(props: ModalPropsWithAccessibleDescription) {
}
}

useEffect(function sauvegardeEtRestorationFocus() {
if (isOpen) {
useEffect(function HandleFocusBeforeOpen() {
if (isOpen && !lastFocusBeforeOpen) {
setLastFocusBeforeOpen(document.activeElement as HTMLElement);
} else {
lastFocusBeforeOpen?.focus();
}

if(!isOpen) setLastFocusBeforeOpen(null);

return () => {
lastFocusBeforeOpen?.focus();
};
}, [isOpen, lastFocusBeforeOpen]);


useEffect(() => {
disableDocumentBodyScroll(isOpen);
trapModalFocus();
Expand Down