[week4,5] howoldareu 리팩토링 및 테스트 코드 15개 작성 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unanchoi
approved these changes
Mar 28, 2024
Comment on lines
+54
to
+56
| assertEquals(Success.CREATE_MEMBER_SUCCESS.getHttpStatus(), result.getCode()); | ||
| assertEquals(Success.CREATE_MEMBER_SUCCESS.getMessage(), result.getMessage()); | ||
| assertEquals(response, result.getData()); |
| ); | ||
|
|
||
| // given(questionService.getQuestionResponseDTOList()).willReturn(List.of(response1, response2)); | ||
| doReturn(List.of(response1, response2)).when(questionService) |
sung-silver
approved these changes
Apr 1, 2024
| mockMvc = MockMvcBuilders.standaloneSetup(memberController).build(); | ||
| } | ||
|
|
||
| // ai가 나보다 잘짠다.. |
| ); | ||
|
|
||
| // given(questionService.getQuestionResponseDTOList()).willReturn(List.of(response1, response2)); | ||
| doReturn(List.of(response1, response2)).when(questionService) |
| .getAllResults(any(Long.class)); | ||
| // when | ||
| ResultActions resultActions = mockMvc.perform( | ||
| MockMvcRequestBuilders.get("/result/1") |
There was a problem hiding this comment.
이런 API ENDPOINT 분리해도 좋지 않을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4-5주차 Test Code 15개 작성했습니다.