TP Reactor was excessively calling select #1157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TP Reactor implementation of the clear_dispatch_mask was implemented by clearing the entire ready set instead of just removing the handler that was suspended. This forced the TP Reactor to potentially dispatch only a single handler before re-calling an expensive select() call and restarting the dispatch with the new set returned from select(). This heavily favored lower order fds and was inefficient. This originated with the fix for ACE bugzilla 1890 which appears to have mainly focused on the single threaded select reactor.
|
What about removing the implementation in TP_Reactor completely and just use the implementation in ACE_Select_Reactor_Impl? |
|
Sure thing, can do. |
|
Though the base class sets state_changed_ to true, won't that reset all the handles in get_event_for_dispatching? I can try to take a deeper look comparing with the older behavior as this was degrading performance for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TP Reactor implementation of the clear_dispatch_mask was implemented
by clearing the entire ready set instead of just removing the handler
that was suspended. This forced the TP Reactor to potentially dispatch
only a single handler before re-calling an expensive select() call and
restarting the dispatch with the new set returned from select(). This
heavily favored lower order fds and was inefficient. This originated
with the fix for ACE bugzilla 1890 which appears to have mainly focused
on the single threaded select reactor.