Exit Early for Several Commands When A Child Process Fails #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created a way to try to make this behavior controllable via an XML attribute: <command name="whatever" required="true"/>Means that if the command fails, then autobuild stops without processing anymore commands. However I'm not quite sure which way the default should go. I'm also considering a required tag and/or a optional tag: <required>
<command name="build core library"/>
</required>
<optional>
<command name="build supplement program"/>
<command name="run test"/>
</optional>Or maybe a default setting: <configuration>
<required default="true"/>
</configuration> |
|
The XML attribute is the least intrusive, we have a lot of autobuild xml files. I think the default is to be false, can't really predict what happens when you set the default to true |
mitza-oci
reviewed
Jan 2, 2019
mitza-oci
requested changes
Jan 21, 2020
Merged
iguessthislldo
added a commit
to iguessthislldo/autobuild
that referenced
this pull request
Apr 20, 2021
Created a new command error return mechanism that distinguishes between fatal and non-fatal errors. This is indented to work with the `required` attribute from DOCGroup#4.
mitza-oci
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought up by OpenDDS#1011 where
apt-get installfailed so OpenDDS configure script failed but every single other command was run anyway, even though they were all failures. I changed several autobuild commands which create child processes so that they fail when their child processes fail.Shares some commits with #3 .