Merging changes of Week 1 through 4 via final branch #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changes in Activity files
…ated RecyclerView code
Changes: ActionBar, RecyclerView UI
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made since week-4 commit:
Added Splash Screen - updated theme in AndroidManifest, changed all Activity screens to show the splash screen, added splash.xml, and corresponding drawable to be displayed.
Refactored Article from Response.kt for RecyclerView model.
Added Bookmark icon to ActionBar to navigate to BookmarksFragment
Added Bookmark entity, BookmarkDao interface, BookmarkRoomDatabase.
Added NewsRepository as a layer between ListViewModel and data observed from RoomDB and Retrofit service. Modified ListViewModel with Room logic and added ViewModelFactory.
Modified NewsFragment to show web view of a selected news article with floating action button to bookmark it.
Updated ListFragment and RecyclerViewAdapter to show divider.