-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #27 Path limit issues #417
base: develop
Are you sure you want to change the base?
Conversation
After fixing the compilation of the develop branch on linux in #418 , I was able to rebase this branch with develop. This still seems to be working. I got my results. |
@fabiooliveira72 Can you put this in your queue for testing? |
Hi @chporter! Yes, for sure. I saw the PR. I will pass through this soon and test it. I have another trip coming next week and Im finishing up the workshop things. Ill Thank you. Fabio Oliveira |
Since new stuff was merged to the |
@fabiooliveira72 Is there any ETA for this testing? Just wondering because if more things get merged then I have to fix conflicts. Note that my dssat nix package got merged in Nixpkgs so anyone can now run dssat with no compilation/dependencies needed with |
Hi @pcboy! Thanks for your patience and checking this. Yes, please keep updated your branch and resolve the conflicts. We need to delay the merge of this pull request because this is a major change that affect all the model. We have an upcoming DSSAT Release that we need to keep stable. I also have some updates for this pull request that I will merge with mine. The problem is the testing of all this. But keep this branch updated. After the release we can get back to this. Thank you so much! |
As I encountered issue #27 , I tried to fix it.
I made a glorified search and replace in a script called ./autofix_paths.rb that we can remove after the PR is reviewed.
The resulting DSSAT seems to be working for me at the moment, with the path issue fixed. I ran a batch file and got my results.
Notes:
The changes I made are from tag(this has been rebased with develop now). The reason is the latest tag does not compile for me on Linux v4.8.2.10 not compiling with gfortran on linux #416 . If that issue gets fixed, I can likely re-run my script.v4.7.5.42
and not fromv4.8.2.10
* text eol=crlf
automatically in the gitattributes? This is something that should be handled by the editors instead. And I'm sure even on windows, editors should be able to handle \n for newlines? This setup caused me issues on my side.