Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #27 Path limit issues #417

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

pcboy
Copy link

@pcboy pcboy commented May 28, 2024

As I encountered issue #27 , I tried to fix it.

I made a glorified search and replace in a script called ./autofix_paths.rb that we can remove after the PR is reviewed.

The resulting DSSAT seems to be working for me at the moment, with the path issue fixed. I ran a batch file and got my results.

Notes:

  • The changes I made are from tag v4.7.5.42 and not from v4.8.2.10 (this has been rebased with develop now). The reason is the latest tag does not compile for me on Linux v4.8.2.10 not compiling with gfortran on linux #416 . If that issue gets fixed, I can likely re-run my script.
  • Why are you * text eol=crlf automatically in the gitattributes? This is something that should be handled by the editors instead. And I'm sure even on windows, editors should be able to handle \n for newlines? This setup caused me issues on my side.
  • This is a bastard search and replace, I did my best as to be fairly specific, but this is likely that some variables are using more stack space than necessary.
  • I can't find any tests in this project at the moment? So I 'm not sure how to make sure I didn't break anything.

@pcboy
Copy link
Author

pcboy commented May 29, 2024

After fixing the compilation of the develop branch on linux in #418 , I was able to rebase this branch with develop.

This still seems to be working. I got my results.

@chporter
Copy link
Contributor

@fabiooliveira72 Can you put this in your queue for testing?

@fabiooliveira72
Copy link
Contributor

Hi @chporter!

Yes, for sure. I saw the PR. I will pass through this soon and test it.

I have another trip coming next week and Im finishing up the workshop things. Ill

Thank you.

Fabio Oliveira

@pcboy
Copy link
Author

pcboy commented Jun 20, 2024

Since new stuff was merged to the develop branch, I rebased.

@pcboy
Copy link
Author

pcboy commented Jul 17, 2024

@fabiooliveira72 Is there any ETA for this testing?

Just wondering because if more things get merged then I have to fix conflicts.

Note that my dssat nix package got merged in Nixpkgs so anyone can now run dssat with no compilation/dependencies needed with nix run github:nixos/nixpkgs/nixos-unstable#dssat , this includes my patch for the path limit in this MR.

@fabiooliveira72
Copy link
Contributor

fabiooliveira72 commented Jul 24, 2024

Hi @pcboy!

Thanks for your patience and checking this.

Yes, please keep updated your branch and resolve the conflicts. We need to delay the merge of this pull request because this is a major change that affect all the model. We have an upcoming DSSAT Release that we need to keep stable. I also have some updates for this pull request that I will merge with mine. The problem is the testing of all this.

But keep this branch updated. After the release we can get back to this.

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants