Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLC-277 Rest Contract changes for Duplicate Detection #198

Conversation

kshepherd
Copy link
Member

Changes to REST contract describing

DSpace Angular PR: DSpace/dspace-angular#1732
DSpace PR: DSpace/DSpace#8415

@pnbecker
Copy link
Member

We are willing to follow this up if it is clear who and when it is being reviewed. We rebased and fixed this PR several times. We would do this one more time if there is a concrete plan how this is being reviewed. We will not rebase again and again until it is clear who and when this will be reviewed. Please ping us or contact us otherwise if you are interested in reviewing it.

@github-actions github-actions bot added the merge conflict PR has a merge conflict that needs resolution label Nov 30, 2023
Copy link

Hi @kshepherd,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@pnbecker
Copy link
Member

I close this PR. We took a new approach on duplicate detection, created new PRs for frontend and backend and will create a new PR for the RestContract soon.

@pnbecker
Copy link
Member

#252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict PR has a merge conflict that needs resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants