Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coar Notify Integration #249

Merged
merged 46 commits into from
Feb 29, 2024
Merged

Coar Notify Integration #249

merged 46 commits into from
Feb 29, 2024

Conversation

frabacche
Copy link
Contributor

@frabacche frabacche commented Dec 1, 2023 •
edited
Loading

Quality Assurance Events and LDN Message Protocol.

Based on these old Pull Requests:

Related to new Pull Requests:

Continues on:

Instructions for Reviewers

Technical implementations documented here : https://wiki.lyrasis.org/pages/viewpage.action?pageId=319815713

eskander and others added 30 commits October 5, 2023 18:22
@abollini
[CST-11046] itemfilters and notifyservices endpoints
f4a7723
@abollini
[CST-11046] refactoring added new response status codes
fd24688
@abollini
[CST-11046] refactoring added new response status codes
44f6fbe 
adding patch operations
@abollini
[CST-11046] refactoring
f6eb499
@abollini
[CST-1104] refactoring and adding new properties to post method
6d021ce
@abollini
[CST-11046] refactoring path value of patch operations
09d8a2e
@abollini
[CST-11046] added new property "enabled"
611c795
@abollini
[CST-11043] submission notify panel
bb9821b
@frabacche
Merge remote-tracking branch '4sciencegithub/CST-5249' into CST-12143
ca9e203
@eskander17
[CST-11043] replaced fields with patterns property
afaac76
@eskander17
[CST-11043] refactoring and handled patch operations
0ebe2af
@eskander17
[CST-11043] refactoring and renamed the endpoint
c0ef462
@eskander17
[CST-11043] replaced services with ids only
c17e1f7
@frabacche
CST-12143 topic by target
4018387
@frabacche
CST-12143 QA Events findByTopic add target get parameter as non-required
aaa4377
@abollini
CST-12143 cleanup wording
27916fe
@frabacche @abollini
Merged in CST-12143 (pull request DSpace#43)
8fa75c5 
CST-12143

Approved-by: Andrea Bollini
@abollini
CST-11403 finalization of the workspaceitem-data structure
de09901
@abollini
CST-11403 add details about return code for patch operation
404ee0b
@eskander17 @abollini
Merged in CST-11043 (pull request DSpace#41)
b089b2b 
[CST-11043] submission notify panel

Approved-by: Andrea Bollini
@eskander17
[CST-11043] changed default to coarnotify
67ddfea
@eskander17
added a new search method
b653401
@abollini
CST-12467 refactor qatopic to always refer to a qasource
2ca153d
@abollini
CST-12467 implement a search by target method for qa sources
e5ea4cf
CST-12469 Added score details in the rest contract
2cebbfc
@abollini
Merged in CST-12467 (pull request DSpace#45)
15e407c 
CST-12467 refactor qatopic to always refer to a qasource
CST-12469 addressed required changes on the ldnservices rest contract
18bb177
CST-11045 Updated reference to the services to use the new id
e0d2354
@abollini
Merged in CST-11045 (pull request DSpace#47)
2a10dfe 
CST-11045 Updated reference to the services to use the new id
@steph-ieffam
[CST-12469] fixed score number
311c5aa
@frabacche frabacche mentioned this pull request Dec 1, 2023
Merged
8 tasks
@frabacche frabacche marked this pull request as draft December 1, 2023 16:13
@github-actions github-actions bot added the merge conflict PR has a merge conflict that needs resolution label Dec 18, 2023
@github-actions GitHub Actions
Copy link

Hi @frabacche,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@frabacche frabacche marked this pull request as ready for review January 12, 2024 09:11
@github-actions github-actions bot removed the merge conflict PR has a merge conflict that needs resolution label Jan 17, 2024
@abollini abollini mentioned this pull request Jan 17, 2024
Merged
@eskander17 @steph-ieffam
Merged in coar-notify-7_CST-13257 (pull request DSpace#56)
9238863 
[CST-13257] added lowerIp and upperIpd

Approved-by: Stefano Maffei
@steph-ieffam steph-ieffam mentioned this pull request Jan 18, 2024
Merged
8 tasks
@FrancescoMolinaro FrancescoMolinaro mentioned this pull request Jan 18, 2024
Merged
8 tasks
@steph-ieffam steph-ieffam mentioned this pull request Jan 18, 2024
Merged
tdonohue
tdonohue reviewed Feb 16, 2024
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reviewing the backend implementation, I've found that the /ldn/inbox is missing from this REST Contract. I'd appreciate it if it can be added, as that while help in the review.

@frabacche
Copy link
Contributor Author

In reviewing the backend implementation, I've found that the /ldn/inbox is missing from this REST Contract. I'd appreciate it if it can be added, as that while help in the review.

this had been added.

tdonohue
tdonohue approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @frabacche . This looks good to me now.

@tdonohue tdonohue added this to the 8.0 milestone Feb 29, 2024
@tdonohue tdonohue added the integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services label Feb 29, 2024
@tdonohue tdonohue merged commit 84e09b2 into DSpace:main Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdonohue tdonohue tdonohue approved these changes

Assignees

@frabacche frabacche

Labels
high priority integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services new feature
Projects
No open projects
DSpace 8.0 Release
Status: ✅ Done
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@frabacche @tdonohue @eskander17 @abollini @steph-ieffam