Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/api/security/csrf: better explain impact on perfomance degradation #283

Merged
merged 1 commit into from
Aug 27, 2024
Merged

/api/security/csrf: better explain impact on perfomance degradation #283

merged 1 commit into from
Aug 27, 2024

Conversation

saschaszott
Copy link
Contributor

No description provided.

@saschaszott
Copy link
Contributor Author

This PR is based on a Slack discussion between @tdonohue and @saschaszott . @tdonohue said

As far as I'm aware there's no way to perform a DoS style attack against the /api/security/csrf endpoint. It's just that clients should use it sparingly because the client's performance will be decreased it if has to request a CSRF token before every single POST/PUT/DELETE.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge. port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Aug 27, 2024
@tdonohue tdonohue added this to the 9.0 milestone Aug 27, 2024
@tdonohue tdonohue merged commit 5773d69 into DSpace:main Aug 27, 2024
1 check passed
@dspace-bot dspace-bot mentioned this pull request Aug 27, 2024
Merged
@dspace-bot
Copy link

Successfully created backport PR for dspace-7_x:

@dspace-bot
Copy link

Successfully created backport PR for dspace-8_x:

@dspace-bot dspace-bot mentioned this pull request Aug 27, 2024
Merged
@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdonohue tdonohue tdonohue approved these changes

Assignees

@saschaszott saschaszott

Labels
1 APPROVAL pull request only requires a single approval to merge.
Projects
DSpace 9.0 Release
Status: ✅ Done
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@saschaszott @dspace-bot @tdonohue