Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit section in sidebar menu: edit page of selected item / collection / community does not refresh #2300

Closed
saschaszott opened this issue Jun 12, 2023 · 2 comments · Fixed by #2308
Assignees
Labels
bug high priority performance / caching Related to performance, caching or embedded objects
Milestone

Comments

@saschaszott
Copy link
Contributor

This bug affects DS 7.5 and it can be reproduced in the DS 7.5 demo instance.

bug description and steps to reproduce

  1. hover over sidebar menu and choose Edit menu section

  2. within menu section choose entry Community, Collection or Item

image

  1. (the following description assumes that a collection was chosen)

image

  1. choose a collection from the collection list that is shown in the modal dialog (in this example 1205TestCollection was chosen)

  2. the edit form of the selected collection is shown

image

  1. go back to step 1 and repeat the process until step 5 (choose another collection in step 5)

After the second pass of step 5 the browser URL changes (from https://demo7.dspace.org/collections/733388bf-9adb-4218-b899-ce22deb27fdd/edit/metadata to https://demo7.dspace.org/collections/33441398-de98-4ec1-86b7-3f57688b1856/edit/metadata), but the form fields are not updated, e.g. in the Name input field the name of the previously chosen collection is still present (marked in the screenshot).

image

If you refresh the page or open https://demo7.dspace.org/collections/33441398-de98-4ec1-86b7-3f57688b1856/edit/metadata directly, the Name input field contains the correct value:

image

The same (buggy) behaviour appears if you choose a community or item in step 2. Any subsequent selection of an another community or item shows the values of the community / item that was initially selected.

@saschaszott saschaszott added bug needs triage New issue needs triage and/or scheduling labels Jun 12, 2023
@tdonohue
Copy link
Member

tdonohue commented Jun 12, 2023

I can reproduce this locally... the steps are pretty simple & unfortunately occur both for "Edit -> Community" or "Edit -> Collection".

  1. Go to "Edit -> Community" (or "Edit -> Collection")
  2. Select a Community (or Collection). It doesn't matter which one, but pay attention to which you have selected
  3. Go back to the same "Edit -> Community" (or "Edit -> Collection"). Make sure it's the same type of edit... e.g. if you previously selected a Community, then select "Edit -> Community" again.
  4. Select a different Community (or Collection). Bug: Look closely. The form still contains the metadata of the previously selected Community or Collection.

I'll see if anyone can dig into this. It appears to be a caching issue with the form. If you reload the page, the form then reloads properly.

@tdonohue tdonohue added performance / caching Related to performance, caching or embedded objects high priority and removed needs triage New issue needs triage and/or scheduling labels Jun 12, 2023
@saschaszott
Copy link
Contributor Author

Thanks, @tdonohue . Items are also affected.

Normally, the UUIDs in the URL and in the Item internal ID match.

image

If the caching issue appears, the UUIDs do not match

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug high priority performance / caching Related to performance, caching or embedded objects
Projects
No open projects
Status: Done
3 participants