Edit section in sidebar menu: edit page of selected item / collection / community does not refresh

[alisaismailati]

References

• Fixes edit section in sidebar menu: edit page of selected item / collection / community does not refresh #2300

Description

Fixed the behavior of collection/community/item components in order to initialize the form correctly and to ensure that the item's template is always up to date.

Instructions for Reviewers

List of changes in this PR:

• First, the initialization of CollectionMetadataComponent is changed in order to ensure that the item's template is always up to date. To do so it is checked if the NavigationEnd or a Scroll event followed by a NavigationEnd event is finished.
  This way we track the URL change or the refresh of the page.
• Second, in CollectionFormComponent the logic from the ngOnInit is separated to a new method initializeForm() , in order to call this method on ngOnChanges . Since we get the data as Input, we need to initialize the form as often as the data changes (the component is initialized only once).
• Other changes include removing first() operator from the pipe when getting so latest data from route, because it was causing the page to not load the new data when the user navigates to the page after choosing a new element to edit.
• Lastly, is worked on unit tests on src/app/collection-page/edit-collection-page/collection-metadata/collection-metadata.component.spec.ts, in order to provide and mock the Router.

Include guidance for how to test or review your PR.
Steps to reproduce the behavior are the same as mentioned on #2300.

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

👍 Thanks @alisaismailati ! This has fixed all the bugs listed in #2300

• Verified editing one community and then another causes the "Edit Community" form to reload
• Verified editing one collection and then another causes the "Edit Collection" form to reload
• Verified editing one Item and then another, causes the Item Status page to reload.