Feat/collect entity #253
Closed
Feat/collect entity #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyFBB
reviewed
Feb 1, 2024
LuckyFBB
reviewed
Feb 1, 2024
| } from '../common/entityCollector'; | ||
|
|
||
| export default class MySqlEntityCollector extends EntityCollector implements MySqlParserListener { | ||
| combineRootStmtEntities( |
There was a problem hiding this comment.
我理解当我们搜集的类型都是一样的时候，是不是所有 SQL 的 combineRootStmtEntities 都是一样的？
为什么需要每一种都SQL都实现一次 combineRootStmtEntities 讷？🤔
There was a problem hiding this comment.
不同的 SQL 的实体聚合逻辑可能不一样，开放这个方法用于SQL 自定义聚合逻辑。只是目前支持的情况比较简单，所以看起来所有sql都一样
| CREATE TABLE new_tb_from_old AS | ||
| SELECT | ||
| old_tb1.column1, | ||
| old_tb2.column2 |
There was a problem hiding this comment.
对于 column1/column2 作为了 new_tb_from_old 的字段，需要被收集吗？
There was a problem hiding this comment.
目前无法将查询的字段与查询条件中的字段区分开，所以暂时没做
Merged
|
support Hive @LuckyFBB |
|
support PostgreSQL @HaydenOrz |
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 已经转移至 #265