Skip to content

Commit

Permalink
feat: export "incomplete" settings in completionService (#101)
Browse files Browse the repository at this point in the history
Co-authored-by: wan.jie <[email protected]>
  • Loading branch information
Kijin-Seija and wan.jie committed Jan 26, 2024
1 parent bdcd8ab commit 7567b5b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/_.contribution.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export type CompletionService = (
position: Position,
completionContext: languages.CompletionContext,
suggestions: Suggestions | null
) => Promise<ICompletionItem[]>;
) => Promise<ICompletionItem[] | { completionItems: ICompletionItem[], incomplete: boolean }>;

export interface LanguageServiceDefaults {
readonly languageId: string;
Expand Down
7 changes: 4 additions & 3 deletions src/languageFeatures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,8 @@ export class CompletionAdapter<T extends IWorker> implements languages.Completio
position.lineNumber,
wordInfo.endColumn
);

const completionItems: languages.CompletionItem[] = completions.map((item) => ({
const unwrappedCompletions = Array.isArray(completions) ? completions : completions.completionItems
const completionItems: languages.CompletionItem[] = unwrappedCompletions.map((item) => ({
...item,
insertText:
item.insertText ??
Expand All @@ -183,7 +183,8 @@ export class CompletionAdapter<T extends IWorker> implements languages.Completio
}));

return {
suggestions: completionItems
suggestions: completionItems,
incomplete: Array.isArray(completions) ? undefined : completions.incomplete
};
});
}
Expand Down

0 comments on commit 7567b5b

Please sign in to comment.