Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of "queryunbuffered", and correctness of "first" APIs #2121

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Improve performance of "queryunbuffered", and correctness of "first" APIs #2121

merged 2 commits into from
Oct 9, 2024

Conversation

mgravell
Copy link
Member

@mgravell mgravell commented Oct 8, 2024 •
edited
Loading

see #2115

  • correctness: do no use SingleRow by default; affects trailing errors
  • performance: QueryUnbufferedAsync can mirror cmd?.Cancel() in finally (this is consistent with all other scenarios)

@mgravell
see #2115
da781c4 
- correctness: do no use SingleRow by default; affects trailing errors
- performance: QueryUnbufferedAsync can mirror cmd?.Cancel() in finally (this is consistent with all other scenarios)
@mgravell mgravell changed the title Improve performance and correctness of "first" APIs Improve performance of "queryunbuffered", and correctness of "first" APIs Oct 8, 2024
mgravell added a commit to DapperLib/DapperAOT that referenced this pull request Oct 8, 2024
@mgravell
consistent changes with DapperLib/Dapper#2121
60c12e1
@mgravell mgravell merged commit b4f80b6 into main Oct 9, 2024
2 checks passed
@mgravell mgravell deleted the single-perf branch October 9, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mgravell