Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add furi_hal_version_uid_default (Fix TOTP) #502

Merged
merged 2 commits into from
Jun 4, 2023
Merged

Add furi_hal_version_uid_default (Fix TOTP) #502

merged 2 commits into from
Jun 4, 2023

Conversation

ClaraCrazy
Copy link

@ClaraCrazy ClaraCrazy commented Jun 4, 2023

What's new

  • Added new API route furi_hal_version_uid_default (Fixes TOTP)

Verification

  • Open Authenticator (TOTP) app without namespoof on current version
  • Use namespoof, observe "Digital signature verification - failed"
  • Change ext/totp/services/crypto.c#L93 to use new API route, observe working even with namespoof

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@ClaraCrazy ClaraCrazy requested a review from xMasterX as a code owner June 4, 2023 08:53
@ClaraCrazy
Copy link
Author

App itself will need some logic to check for either uid, or uid_default. or should we perhaps keep furi_hal_version_uid original, and make ours _custom, to not confuse app developers?

@xMasterX
Copy link
Member

xMasterX commented Jun 4, 2023

App itself will need some logic to check for either uid, or uid_default. or should we perhaps keep furi_hal_version_uid original, and make ours _custom, to not confuse app developers?

Since this is only custom app that uses it, and we need to change UID across all system in easy way when using name changer, current solution seems fine, we can select what app will be using by using defines in app itself

Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Ill make needed changes in app with defines

@xMasterX xMasterX merged commit a7a51b7 into DarkFlippers:dev Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants