Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte input add feature: editor without keyboard #509

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

gid9798
Copy link
Collaborator

@gid9798 gid9798 commented Jun 8, 2023

What's new

  • Byte input add feature: editor without keyboard

index <9

no_keyboard

index 9 - 99

many_bytes

index 99+

99+

Verification

  • Press the up button until a new editor appears
  • Up/Down inc/dec selected nibble
  • Left/Right change selected nibble
  • Back to return to the keyboard

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gid9798 gid9798 requested a review from xMasterX as a code owner June 8, 2023 11:14
Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xMasterX xMasterX merged commit 1a6b201 into DarkFlippers:dev Jun 9, 2023
@gid9798 gid9798 deleted the byte_input_mini_editor branch June 12, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants