Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubGhz App #516

Merged
merged 5 commits into from
Jul 2, 2023
Merged

SubGhz App #516

merged 5 commits into from
Jul 2, 2023

Conversation

gid9798
Copy link
Collaborator

@gid9798 gid9798 commented Jun 14, 2023 •
edited by xMasterX
Loading

What's new

  • SubGhz App: remove kostily and velosipedy
    • Now uses flags
    • The check can be moved to /lib/subghz/receiver.c, but may result in false positives. Not detected on the current set of protocols
  • Removed duplicate code when adding custom presets

Verification

  • Need additional checks for protocol_ignore

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@xMasterX xMasterX marked this pull request as ready for review July 2, 2023 12:04
@xMasterX xMasterX self-requested a review as a code owner July 2, 2023 12:04
@xMasterX xMasterX merged commit 9d09aa4 into DarkFlippers:dev Jul 2, 2023
@gid9798 gid9798 deleted the subghz/code_improvement branch July 14, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Breakdancer888 Breakdancer888 Breakdancer888 approved these changes

@xMasterX xMasterX Awaiting requested review from xMasterX xMasterX is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gid9798 @EvanCarroll @ALEEF02 @Breakdancer888 @xMasterX