Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor frequency analyzer code for better readability #782

Merged

Conversation

derskythe
Copy link
Contributor

@derskythe derskythe commented Jul 24, 2024

What's new

  • Fix invalid array for loop. Macro ARRAY_SIZE
  • Add correct check for float == 0
  • Remove duplicated code
  • Refactor to improve structure and readability of the frequency analyzer code

Verification

  • Everything was tested

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Refactor to improve structure and readability of the frequency analyzer code. This includes added comments, updating variable names, and reorganizing the frequency list for clarity. The changes also address initialization issues and clean up repetitive code blocks.
@derskythe derskythe requested a review from xMasterX as a code owner July 24, 2024 14:14
@xMasterX xMasterX merged commit 121b5e0 into DarkFlippers:dev Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants