You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am currently implementing dashjs 2.4 instead of dashjs 2.3, but I have an error to load dashjs library. As all my website use requirejs, I load dashjs with the requirejs "shim" option (as it doesn't support AMD).
All was ok with 2.3, but with 2.4, the xml2json external library has been updated and it now use AMD. So, X2JS variable is not defined on the window object :
This was added in order to keep as close to the original xml2json as possible. Since we have forked the library anyway, that code can be removed and an export statement used as previously.
Hello,
I am currently implementing dashjs 2.4 instead of dashjs 2.3, but I have an error to load dashjs library. As all my website use requirejs, I load dashjs with the requirejs "shim" option (as it doesn't support AMD).
All was ok with 2.3, but with 2.4, the xml2json external library has been updated and it now use AMD. So, X2JS variable is not defined on the window object :
Commit : 5aa8931
Would you be able to standardize that, by using amd for all modules, or by removing amd support on xml2json library ?
Regards,
David
The text was updated successfully, but these errors were encountered: