dynamically choose between ThroughputRule and BolaRule #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbryer
approved these changes
Jul 19, 2017
src/streaming/MediaPlayer.js
Outdated
| @@ -2110,6 +2078,34 @@ function MediaPlayer() { | |||
|
|
|||
| --------------------------------------------------------------------------- | |||
| */ | |||
|
|
|||
| /** | |||
| * @deprecated Since version 2.6.0. | |||
There was a problem hiding this comment.
It's deprecated if it's no longer the preferred way to do it, but it still works. If it completely doesn't work, it's obsolete.
|
Thanks. I don't have any more changes planned here other than fixes for issues that come up during review and testing. |
dsparacio
reviewed
Aug 8, 2017
| * @instance | ||
| */ | ||
| function setABRStrategy(value) { | ||
| if (value === Constants.ABR_STRATEGY_DYNAMIC || value === Constants.ABR_STRATEGY_BOLA || value === Constants.ABR_STRATEGY_THROUGHPUT) { |
There was a problem hiding this comment.
Is it time to create a public facing TYPES object accessible from outside Dash.js?
|
@robertbryer I was wondering if you have done any A/B testing on this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR dynamically chooses between ThroughputRule and BolaRule to get strengths of both.
A new stream starts on ThroughputRule and then switches to BolaRule when the buffer level reaches a threshold, switching back to ThroughputRule when the buffer level drops below a (lower-than-the-first) threshold and so on.
Note that while the automatic rule switching gets the best of both rules, both ThroughputRule and BolaRule can work well without the other.
After this change, the rich buffer rule is no longer needed. The rich buffer rule code in the AbrController is replaced by the new switching mechanism.
This PR builds on two previous ones:
#2003 introduced ThroughputHistory, reducing duplication (there was similar code in both ThroughputRule and BolaRule). ThroughputHistory also helps keep track of throughput even when the ThroughputRule is not active. Also, InsufficientBufferRule was updated to better handle low-buffer situations.
#2068 updated BolaRule to work alongside other rules, mainly by no longer assuming it is the only rule active. Particularly, if BolaRule is used after another rule has been used for a while, BolaRule will take the previous rule’s bitrate into account to avoid bitrate oscillations.