Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min max playback rate #4054

Merged

Conversation

mattjuggins
Copy link
Contributor

See #3990

  • Separate playbackRate into a min and max value. This means the application of rates can be the same between ServiceDescription and dash.js settings.
  • Applies playback rates of value 1.0 if explicitly set.
  • Modify catch-up algorithms to take into account these separate playback rate values.
  • Update sample to take into account min and max playback rate values.

Some additional thought may be required on default playback rate fallback values, and whether to limit the range of possible values (again, see #3990).

@dsilhavy dsilhavy added this to the 4.6.0 milestone Sep 24, 2022
samples/low-latency/testplayer/main.js Outdated Show resolved Hide resolved
src/streaming/models/MediaPlayerModel.js Outdated Show resolved Hide resolved
src/streaming/models/MediaPlayerModel.js Outdated Show resolved Hide resolved
src/streaming/controllers/CatchupController.js Outdated Show resolved Hide resolved
@dsilhavy dsilhavy merged commit 07142a9 into Dash-Industry-Forum:development Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants