Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish docker image with Github Action #211

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

CCMA-Enginyeria
Copy link

Hi livesim2 team,

We've added a new GitHub action to create a Docker image. Additionally, we found an issue with the Go language image version. We fixed it by setting the version to 1.23, as it wasn't compatible with the latest version, and updated it accordingly.

Thank you!
Best regards

@tobbee
Copy link
Contributor

tobbee commented Sep 27, 2024

@CCMA-Enginyeria Thanks for your PR.

In my view, the current Dockerfile is not good enough for publishing.
A minimal thing is to add a Version into the image, so I made a PR for including that #212

Regarding content, this image only includes the test content that is typically 8s long. Do you think that is enough to be useful?

One can otherwise try to download more content on start of the container as is done in entrypoint.sh in https://github.com/eyevinn-osaas/livesim2/blob/main/Dockerfile.

What is your view on that?

@rbermudezg
Copy link
Contributor

Hi @tobbee!

For us, it's already very useful as it is because we use it by mounting a volume in the vod subfolder. We have a docker-compose.yml like this:

services:
  livesim2:
    image: ghcr.io/ccma-enginyeria/livesim2/livesim2:latest
    ports:
      - 8888:8888
    volumes:
      - ./test_streams:/vod/test_streams
    restart: always

If you think that kind of information would be useful to add to the README.md, let us know.

Thank you!

@tobbee
Copy link
Contributor

tobbee commented Oct 11, 2024

@rbermudezg thanks for your response. Your approach seems to be a good way of adding other content.

I don't have any credentials set up for ghcr yet, but will look into that.

@tobbee tobbee merged commit e19dd97 into Dash-Industry-Forum:main Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants