Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block benign warning from Google library (#2228) #2614

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

jessebrennan
Copy link
Contributor

@jessebrennan jessebrennan commented Dec 10, 2020

Author (check before every review)

  • PR title references issue
  • Title of main commit references issue
  • PR is linked to Zenhub issue
  • Added DCP/1 label or this PR does not target an hca/* branch
  • Created issue to track porting these changes or this PR does not need porting
  • Added r tag to commit title or this PR does not require reindexing
  • Added reindex label to PR or this PR does not require reindexing
  • Freebies are blocked on this PR or there are no freebies in this PR
  • Freebies are referenced in commit titles or there are no freebies in this PR
  • This PR is blocked by previous PR in chain or this PR is not chained to another PR
  • Added chain label to the blocking PR or this PR is not chained to another PR
  • Ran make requirements_update or this PR leaves requirements*.txt, common.mk and Makefile untouched
  • Added R tag to commit title or this PR leaves requirements*.txt untouched
  • Added reqs label to PR or this PR leaves requirements*.txt untouched
  • Documented upgrading of deployments in UPGRADING.rst or this PR does not require upgrading
  • Added u tag to commit title or this PR does not require upgrading
  • Added upgrade label to PR or this PR does not require upgrading
  • make integration_test passes in personal deployment or this PR does not touch functionality that could break the IT
  • Rebased branch on develop

Primary reviewer (before pushing merge commit)

  • Checked reindex label and r commit title tag
  • Rebased and squashed branch
  • Sanity-checked history
  • Build passes in sandbox or added no sandbox label
  • Reindexed sandbox or this PR does not require reindexing
  • Added PR reference to merge commit
  • Moved linked issue to Merged
  • Pushed merge commit to Github

Primary reviewer (after pushing merge commit)

  • Moved freebies to Merged column or there are no freebies in this PR
  • Shortened chain or this PR is not the base of another PR
  • Verified that N reviews labelling is accurate
  • Commented on demo expectations or labeled as no demo
  • Pushed merge commit to Gitlab or this changes can be pushed later, together with another PR
  • Reindexed dev or this PR does not require reindexing
  • Deleted PR branch from Github and Gitlab
  • Unassign reviewer from PR

@github-actions github-actions bot added the orange [process] Done by the Azul team label Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #2614 (d87560b) into develop (dd7ca3d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2614   +/-   ##
========================================
  Coverage    83.38%   83.38%           
========================================
  Files          125      125           
  Lines        12919    12919           
========================================
  Hits         10772    10772           
  Misses        2147     2147           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7ca3d...d87560b. Read the comment docs.

@coveralls
Copy link

coveralls commented Dec 10, 2020

Coverage Status

Coverage remained the same at 83.308% when pulling d87560b on issues/jessebrennan/2228-google-warning into dd7ca3d on develop.

@amarjandu amarjandu removed their assignment Dec 11, 2020
Copy link
Member

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really eliminate all the back traces from https://gitlab.dev.singlecell.gi.ucsc.edu/snippets/7#LC41?

@hannes-ucsc hannes-ucsc added the 0 reviews [process] Lead didn't request any changes label Dec 18, 2020
@hannes-ucsc hannes-ucsc removed their assignment Dec 18, 2020
Copy link
Member

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have discussed orally but I'd like to see a written response to

#2614 (review)

for the record. No bump.

@hannes-ucsc hannes-ucsc removed their assignment Dec 24, 2020
@jessebrennan
Copy link
Contributor Author

@hannes-ucsc
Copy link
Member

For demo, disable the fix, show the warning, re-enable the fix and show that the warning disappears.

@amarjandu amarjandu force-pushed the issues/jessebrennan/2228-google-warning branch from ef40dc6 to d87560b Compare January 20, 2021 00:17
@amarjandu amarjandu merged commit 62f8093 into develop Jan 20, 2021
@amarjandu amarjandu deleted the issues/jessebrennan/2228-google-warning branch January 20, 2021 01:13
@amarjandu amarjandu removed their assignment Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 reviews [process] Lead didn't request any changes orange [process] Done by the Azul team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants