-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block benign warning from Google library (#2228) #2614
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2614 +/- ##
========================================
Coverage 83.38% 83.38%
========================================
Files 125 125
Lines 12919 12919
========================================
Hits 10772 10772
Misses 2147 2147 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really eliminate all the back traces from https://gitlab.dev.singlecell.gi.ucsc.edu/snippets/7#LC41?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may have discussed orally but I'd like to see a written response to
for the record. No bump.
Yes, it suppresses this warning https://github.com/googleapis/google-api-python-client/blob/9a25cc84e5174e06a82ff74058a8648b79652872/googleapiclient/discovery_cache/__init__.py#L44 which is what logs the stack traces. |
For demo, disable the fix, show the warning, re-enable the fix and show that the warning disappears. |
ef40dc6
to
d87560b
Compare
Author (check before every review)
DCP/1
label or this PR does not target anhca/*
branchr
tag to commit title or this PR does not require reindexingreindex
label to PR or this PR does not require reindexingchain
label to the blocking PR or this PR is not chained to another PRmake requirements_update
or this PR leaves requirements*.txt, common.mk and Makefile untouchedR
tag to commit title or this PR leaves requirements*.txt untouchedreqs
label to PR or this PR leaves requirements*.txt untouchedu
tag to commit title or this PR does not require upgradingupgrade
label to PR or this PR does not require upgradingmake integration_test
passes in personal deployment or this PR does not touch functionality that could break the ITdevelop
Primary reviewer (before pushing merge commit)
reindex
label andr
commit title tagsandbox
or addedno sandbox
labelsandbox
or this PR does not require reindexingPrimary reviewer (after pushing merge commit)
N reviews
labelling is accurateno demo
dev
or this PR does not require reindexing