-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies 2024-03-04 (#6007) #6019
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsotirho-ucsc
added
deploy:shared
[process] PR requires deploying `shared` component
deploy:gitlab
[process] PR requires deploying `gitlab` component
labels
Mar 6, 2024
dsotirho-ucsc
force-pushed
the
upgrades/2023-03-04
branch
from
March 6, 2024 02:08
b21cd7b
to
e29350e
Compare
dsotirho-ucsc
added
the
reqs
[process] PR includes commit requiring ``make requirements``
label
Mar 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6019 +/- ##
========================================
Coverage 85.31% 85.31%
========================================
Files 154 154
Lines 19919 19919
========================================
Hits 16993 16993
Misses 2926 2926 ☔ View full report in Codecov by Sentry. |
dsotirho-ucsc
force-pushed
the
upgrades/2023-03-04
branch
from
March 6, 2024 16:54
e29350e
to
ead1570
Compare
hannes-ucsc
previously approved these changes
Mar 6, 2024
Security design review
|
hannes-ucsc
added
1 review
[process] Lead requested changes once
and removed
0 reviews
[process] Lead didn't request any changes
labels
Mar 6, 2024
For some reason, the top-level checkboxes on the issue weren't checked. |
dsotirho-ucsc
force-pushed
the
upgrades/2023-03-04
branch
from
March 7, 2024 03:27
ead1570
to
5982479
Compare
dsotirho-ucsc
added
the
sandbox
[process] Resolution is being verified in sandbox deployment
label
Mar 8, 2024
hannes-ucsc
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1 review
[process] Lead requested changes once
deploy:gitlab
[process] PR requires deploying `gitlab` component
deploy:shared
[process] PR requires deploying `shared` component
orange
[process] Done by the Azul team
reqs
[process] PR includes commit requiring ``make requirements``
sandbox
[process] Resolution is being verified in sandbox deployment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected issue: #6007
Checklist
Author
develop
upgrades/yyyy-mm-dd
Upgrade dependencies yyyy-mm-dd
Author (upgrading deployments)
u
tag to commit title or this PR does not require upgrading deploymentsmake image_manifests.json
and committed the resulting changes or this PR does not modifyazul_docker_images
, or any other variables referenced in the definition of that variableupgrade
or does not require upgrading deploymentsdeploy:shared
or does not modifyimage_manifests.json
, and does not require deploying theshared
component for any other reasondeploy:gitlab
or does not require deploying thegitlab
componentdeploy:runner
or does not require deploying therunner
imageAuthor (before every review)
develop
, squashed old fixupsmake requirements_update
or this PR does not modifyrequirements*.txt
,common.mk
,Makefile
andDockerfile
R
tag to commit title or this PR does not modifyrequirements*.txt
reqs
or does not modifyrequirements*.txt
make integration_test
passes in personal deployment or this PR does not modify functionality that could affect the IT outcomeSystem administrator (after approval)
no demo
Operator (before pushing merge the commit)
develop
_select dev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused
or this PR is not labeleddeploy:shared
_select dev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply
or this PR is not labeleddeploy:gitlab
_select anvildev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused
or this PR is not labeleddeploy:shared
_select anvildev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply
or this PR is not labeleddeploy:gitlab
_select anvilprod.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused
or this PR is not labeleddeploy:shared
_select anvilprod.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply
or this PR is not labeleddeploy:gitlab
deploy:gitlab
deploy:gitlab
System administrator
dev.gitlab
are complete or this PR is not labeleddeploy:gitlab
anvildev.gitlab
are complete or this PR is not labeleddeploy:gitlab
anvilprod.gitlab
are complete or this PR is not labeleddeploy:gitlab
Operator (before pushing merge the commit)
_select dev.gitlab && make -C terraform/gitlab/runner
or this PR is not labeleddeploy:runner
_select anvildev.gitlab && make -C terraform/gitlab/runner
or this PR is not labeleddeploy:runner
_select anvilprod.gitlab && make -C terraform/gitlab/runner
or this PR is not labeleddeploy:runner
sandbox
labeldev
anvildev
anvilprod
sandbox
deploymentanvilbox
deploymenthammerbox
deploymentsandbox
deploymentanvilbox
deploymenthammerbox
deploymentp
tagsOperator (after pushing the merge commit)
dev
anvildev
anvilprod
dev
dev
anvildev
anvildev
anvilprod
anvilprod
_select dev.shared && make -C terraform/shared apply
or this PR is not labeleddeploy:shared
_select anvildev.shared && make -C terraform/shared apply
or this PR is not labeleddeploy:shared
_select anvilprod.shared && make -C terraform/shared apply
or this PR is not labeleddeploy:shared
dev
anvildev
anvilprod
Operator
script/export_inspector_findings.py
againstanvilprod
, imported results to Google Sheet and posted screenshot of relevant1 findings as a comment on the connected issue.deploy:shared
,deploy:gitlab
,deploy:runner
,reindex:partial
andreindex:prod
labels to the next promotion PR or this PR carries none of these labelsdeploy:shared
,deploy:gitlab
,deploy:runner
,reindex:partial
andreindex:prod
labels from the description of this PR to that of the next promotion PR or this PR carries none of these labels1A relevant finding is a high or critical vulnerability in an image
that is used within the security boundary. Images not used within the boundary
are tracked in
azul.docker_images
under a key starting with_
.System administrator
No currently reported vulnerability requires immediate attentionSee Upgrade to Docker 25.x #6072Shorthand for review comments
L
line is too longW
line wrapping is wrongQ
bad quotesF
other formatting problem