Create two bundles: core and rum #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdeprez
force-pushed
the
sdeprez/add_rum_and_core_bundles
branch
from
9423db6
to
49ae6b2
Compare
bcaudan
reviewed
Mar 14, 2019
bcaudan
suggested changes
Mar 14, 2019
| @@ -2,6 +2,11 @@ import { expect } from 'chai' | |||
| import * as request from 'request' | |||
| const baseRequest = request.defaults({ baseUrl: 'http://localhost:3000' }) | |||
|
|
|||
| afterEach(async () => { | |||
| const logs = await browser.getLogs('browser') | |||
| logs.forEach(console.log) | |||
There was a problem hiding this comment.
Is it for debug purpose?
Could we expect to not have browser logs?
There was a problem hiding this comment.
Yes it's to debug failing tests, otherwise you have zero information from the bundle errors / logs. (For instance I had a SyntaxError on page.html that only appeared when logging that).
There was a problem hiding this comment.
what do you think of expecting that there is no browser logs?
It would be harder to miss a browser log
bcaudan
reviewed
Mar 14, 2019
bcaudan
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two entry points for two bundles: core (only log) and rum (core + rum). I did a refacto of the configuration (no need for a class) to be able to add configuration specific to the RUM. I also did not want to expose the log endpoints to the user so I made a bundle special for e2e tests.
I also choose to not
monitorall thestart*methods because it can be tricky to start monitoring when the start monitor itself can fail and that for now we want to know immediately if errors appear here, they are really critical and, arguably, even the customer could want to know about it if the agent does not work at all.-> Anyway we should discuss about the monitor strategy, we won't be able to do anything that we want 😢.