discovery: Explicitly close opened files (#28859)

DataDog · Aug 28, 2024 · 5d954e9 · 5d954e9
1 parent e99ce1d
commit 5d954e9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/pkg/collector/corechecks/servicediscovery/usm/nodejs.go b/pkg/collector/corechecks/servicediscovery/usm/nodejs.go
@@ -96,6 +96,7 @@ func (n nodeDetector) maybeExtractServiceName(filename string) (string, bool) {
 	if err != nil {
 		return "", false
 	}
+	defer file.Close()
 	ok, err := canSafelyParse(file)
 	if err != nil {
 		//file not accessible or don't exist. Continuing searching up

diff --git a/pkg/collector/corechecks/servicediscovery/usm/tomcat.go b/pkg/collector/corechecks/servicediscovery/usm/tomcat.go
@@ -132,6 +132,7 @@ func (te tomcatExtractor) parseServerXML(domainHome string) *tomcatServerXML {
 		log.Debugf("Unable to locate tomcat server.xml (%q). Err: %v", xmlFilePath, err)
 		return nil
 	}
+	defer file.Close()
 	var serverXML tomcatServerXML
 	err = xml.NewDecoder(file).Decode(&serverXML)
 	if err != nil {