Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dsd] Support container-level UDP origin detection #10610

Closed
wants to merge 1 commit into from

Conversation

ahmed-mez
Copy link
Contributor

@ahmed-mez ahmed-mez commented Jan 20, 2022

What does this PR do?

Extend origin detection on UDP by supporting tagger-ready origin strings in dd.internal.prefixed_origin.

Motivation

  • More granular tags (container tags instead of pod tags)
  • Not limited to Kubernetes, and can be a good alternative in environments where origin detection on UDS is not an option (e.g Fargate)

Additional Notes

Client side logic is implemented in DataDog/datadog-go#250

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Deploy the agent with DD_DOGSTATSD_ORIGIN_DETECTION enabled

echo -n "testing.dsd.container:1|g|#foo:bar,dd.internal.prefixed_origin:container_id://<your container ID>" | nc -u -w1 <Agent IP> 8125

You should be able to see container tags attached to the testing.dsd.container metric on the app.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • The appropriate team/.. label has been applied, if known.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@ahmed-mez ahmed-mez changed the title [dsd] Support container entities in dd.internal.entity_id [dsd] Support container-level UDP origin detection Jan 21, 2022
@ahmed-mez ahmed-mez closed this Feb 4, 2022
@dd-devflow dd-devflow bot deleted the ahmed/dsd-entity branch April 19, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant