Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/trace] Remove deprecated function calls #14086

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 28, 2022

What does this PR do?

Two missing function calls to deprecated functions from #14067.

Motivation

open-telemetry/opentelemetry-collector#6417 (comment)

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@mx-psi mx-psi added changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Oct 28, 2022
@mx-psi mx-psi added this to the 7.41.0 milestone Oct 28, 2022
@mx-psi mx-psi marked this pull request as ready for review October 28, 2022 09:23
@mx-psi mx-psi requested a review from a team as a code owner October 28, 2022 09:23
@mx-psi mx-psi merged commit 41e8a2f into main Oct 28, 2022
@mx-psi mx-psi deleted the mx-psi/remove-deprecated branch October 28, 2022 10:03
mx-psi added a commit that referenced this pull request Nov 11, 2022
mx-psi added a commit that referenced this pull request Nov 11, 2022
* Revert "Bump OpenTelemetry Collector dependencies to v0.63.0 (#14067)"

This reverts commit 34610f5.

* Revert "Bump OpenTelemetry Collector dependencies to v0.62.0 (#13860)"

This reverts commit a5fe32e.

* Revert "[pkg/otlp] Make debug section aligned with logging exporter (#14072)"

This reverts commit 057e1f4.

* Revert "[pkg/trace] Remove deprecated function calls (#14086)"

This reverts commit 41e8a2f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants