-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASCII-1400] Update Go experimental libraries in all modules #24356
Conversation
Regression DetectorRegression Detector ResultsRun ID: 1e9d24e6-7179-4fdc-a243-08c0fd574e28 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | -0.83 | [-6.32, +4.67] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.79 | [-1.21, +4.79] |
➖ | file_tree | memory utilization | +0.52 | [+0.40, +0.64] |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.40 | [+0.32, +0.48] |
➖ | trace_agent_msgpack | ingress throughput | +0.03 | [+0.01, +0.04] |
➖ | trace_agent_json | ingress throughput | +0.02 | [-0.00, +0.05] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.20] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.02 | [-0.04, +0.01] |
➖ | process_agent_standard_check_with_stats | memory utilization | -0.08 | [-0.12, -0.03] |
➖ | basic_py_check | % cpu utilization | -0.22 | [-2.68, +2.24] |
➖ | idle | memory utilization | -0.32 | [-0.36, -0.28] |
➖ | otel_to_otel_logs | ingress throughput | -0.32 | [-0.77, +0.13] |
➖ | process_agent_real_time_mode | memory utilization | -0.40 | [-0.44, -0.35] |
➖ | process_agent_standard_check | memory utilization | -0.48 | [-0.54, -0.43] |
➖ | file_to_blackhole | % cpu utilization | -0.83 | [-6.32, +4.67] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -1.43 | [-6.31, +3.46] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
b2613d6
to
b34062d
Compare
b34062d
to
1bb1f88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase your changes on main
?
…/update-go-extended-libs
@julien-lebot done |
…/update-go-extended-libs
…/update-go-extended-libs
/merge |
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 24m) Use |
* chore: update all go experimental lib modules * fix: tidy
* chore: update all go experimental lib modules * fix: tidy
What does this PR do?
Update all modules from the Go experimental repo.
Motivation
Use up-to-date dependencies.
Often the root module of the repo is kept updated but individual modules are still indicating very old versions of some dependencies.
New versions can include bug and security fixes so we should use them if it doesn't break anything.
Additional Notes
Used the task introduced by #24346:
I did not update
golang.org/x/tools
because it makes some linter fail,golang.org/x/exp
because it depends ongolang.org/x/tools
.Possible Drawbacks / Trade-offs
Describe how to test/QA your changes