Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP OTel Agent e2e pipeline tests #28866

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

liustanley
Copy link
Contributor

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@github-actions github-actions bot added the team/opentelemetry OpenTelemetry team label Aug 28, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 28, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=43077236 --os-family=ubuntu

Note: This applies to commit aa83c20

@pr-commenter
Copy link

pr-commenter bot commented Aug 28, 2024

Regression Detector

Regression Detector Results

Run ID: d40b2f14-4db4-4322-b8ba-04e1ea3b1598 Metrics dashboard Target profiles

Baseline: cd5b295
Comparison: aa83c20

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
idle memory utilization +0.72 [+0.68, +0.76] Logs
basic_py_check % cpu utilization +0.44 [-2.19, +3.07] Logs
otel_to_otel_logs ingress throughput +0.19 [-0.62, +1.01] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
tcp_syslog_to_blackhole ingress throughput -0.05 [-12.96, +12.86] Logs
file_tree memory utilization -0.18 [-0.24, -0.12] Logs
pycheck_lots_of_tags % cpu utilization -0.26 [-2.69, +2.18] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.15 [-2.10, -0.21] Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant