Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPM] Add Enhanced TLS Tags #30187

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

[NPM] Add Enhanced TLS Tags #30187

wants to merge 19 commits into from

Conversation

akarpz
Copy link
Contributor

@akarpz akarpz commented Oct 16, 2024

What does this PR do?

Adds eBPF side logic to parse the TLS hello packet payloads and extract the:

  • client supported versions
  • server chosen version
  • server chosen cipher suite

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@akarpz akarpz changed the title init [NPM] Add Enhanced TLS Tags Oct 16, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 17, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=49095189 --os-family=ubuntu

Note: This applies to commit d3b426c

Copy link

cit-pr-commenter bot commented Oct 18, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: aa30bac5-45df-4ed2-b0c9-9d5ea69b0b0f

Baseline: a7db6c7
Comparison: d3b426c
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +1.42 [+1.31, +1.52] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +1.26 [+0.53, +1.99] 1 Logs
file_tree memory utilization +0.71 [+0.59, +0.84] 1 Logs
quality_gate_idle memory utilization +0.69 [+0.64, +0.73] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.10 [-0.39, +0.59] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.05 [-0.43, +0.53] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.21, +0.28] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.08, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.31, +0.32] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.49, +0.47] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.08 [-0.28, +0.12] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.23 [-0.28, -0.17] 1 Logs
otel_to_otel_logs ingress throughput -0.40 [-1.09, +0.29] 1 Logs
basic_py_check % cpu utilization -1.15 [-4.94, +2.64] 1 Logs
pycheck_lots_of_tags % cpu utilization -3.05 [-6.44, +0.34] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle memory_usage 3/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 6/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@github-actions github-actions bot added the medium review PR review might take time label Nov 6, 2024
Copy link

cit-pr-commenter bot commented Nov 12, 2024

Go Package Import Differences

Baseline: a7db6c7
Comparison: d3b426c

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
iot-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
iot-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
heroku-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
cluster-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
cluster-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
process-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
process-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
process-agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
process-agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
process-agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
heroku-process-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
system-probelinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
system-probelinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls
system-probewindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/network/protocols/tls

@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Nov 13, 2024
@akarpz akarpz added the qa/done Skip QA week as QA was done before merge and regressions are covered by tests label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/system-probe long review PR is complex, plan time to review it qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/networks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant