-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements AllSettings getters #30909
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=48786083 --os-family=ubuntu Note: This applies to commit ba79e2d |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: f036977 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | pycheck_lots_of_tags | % cpu utilization | +3.29 | [-0.19, +6.78] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | +1.94 | [-2.04, +5.92] | 1 | Logs |
➖ | file_tree | memory utilization | +0.98 | [+0.85, +1.11] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.60 | [+0.55, +0.64] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle_all_features | memory utilization | +0.33 | [+0.23, +0.43] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.08 | [-0.40, +0.56] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.44, +0.50] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.02 | [-0.22, +0.27] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.02 | [-0.46, +0.49] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.08, +0.11] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.35, +0.33] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.12 | [-0.30, +0.06] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.22 | [-0.88, +0.44] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.33 | [-0.42, -0.24] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.57 | [-1.29, +0.14] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | quality_gate_idle | memory_usage | 4/10 | bounds checks dashboard |
❌ | file_to_blackhole_100ms_latency | lost_bytes | 6/10 | |
❌ | quality_gate_idle_all_features | memory_usage | 9/10 | bounds checks dashboard |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
f5e186a
to
098d809
Compare
098d809
to
69ed931
Compare
6ac5fb6
to
ba79e2d
Compare
/merge |
Devflow running:
|
What does this PR do?
Implements
AllSettings*
getters. Those mimic the behavior from viper.Describe how to test/QA your changes
Unit test were added. This code is not used anywhere for now. We're building a replacement for viper and will QA it entirely, outside of unit-tests, once it's ready.