-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] add a container context on custom events #31095
base: main
Are you sure you want to change the base?
Conversation
pkg/security/probe/probe_linux.go
Outdated
|
||
cid, err := utils.GetProcContainerID(uint32(pid), uint32(pid)) | ||
if err != nil { // could fail if not in container | ||
return acc, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be returning nil
and the error here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tru. I though the func returns an error if no containerID is found, but it doesn't. Fixed on last commit. Thanks!
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: c6e8fa0 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.13 | [+1.40, +2.86] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | +1.49 | [-1.97, +4.94] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | +1.19 | [-2.60, +4.98] | 1 | Logs |
➖ | file_tree | memory utilization | +0.53 | [+0.41, +0.65] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.29 | [+0.24, +0.35] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle_all_features | memory utilization | +0.26 | [+0.16, +0.36] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.11 | [-0.37, +0.60] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.11 | [-0.35, +0.56] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.00 | [-0.33, +0.33] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.09, +0.07] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.06 | [-0.31, +0.18] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.08 | [-0.14, -0.02] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.10 | [-0.59, +0.38] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.11 | [-0.30, +0.09] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.37 | [-1.06, +0.32] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | file_to_blackhole_100ms_latency | lost_bytes | 5/10 | |
❌ | quality_gate_idle | memory_usage | 5/10 | bounds checks dashboard |
❌ | file_to_blackhole_0ms_latency | lost_bytes | 7/10 | |
❌ | quality_gate_idle_all_features | memory_usage | 8/10 | bounds checks dashboard |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
What does this PR do?
It adds a "container" section to custom events, containing the containerid (if any) and the createat (equals to the exec time of sysprobe).
Motivation
Having the containerID filled on custom events on side pannels (and being able to filter on them easily etc)
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes