[Docker Check] add kernel memory usage metric #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hkaj
reviewed
May 2, 2019
Signed-off-by: Chris Gianelloni <[email protected]>
|
@hkaj can I get a review when you have time? I've addressed your comments. |
|
thanks @wolf31o2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extends Docker check to provide Kernel Memory Usage Metric
Containers run under cgroups with kernel memory accounting enabled will consume kernel memory which needs to be tracked.
Motivation
Running Docker under CentOS 7 and hitting issues described in runc and Mesosphere DC/OS
Additional Notes
This metric will be zero under newer Docker (18.09) and CentOS 7 kernels. Running containers will memory limits (not kernel memory limits) under CentOS 7 with Docker 17.06 will account usage. Modern Docker on a modern kernel requires setting kernel memory limits when starting the container for this metric to take effect.
This is the Agent 6 implementation of DataDog/integrations-core#3339