Allow Table Widget requests to specify text replace formatting in dashboards #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![api-clients-generation-pipeline[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
api-clients-generation-pipeline
bot
requested a review
from a team
as a code owner
src/datadog_api_client/v1/model/table_widget_text_format_rule_main.py
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
src/datadog_api_client/v1/model/table_widget_text_format_replace_substring.py
Show resolved
Hide resolved
| "_with": "with", | ||
| } | ||
|
|
||
| def __init__(self_, type: TableWidgetTextFormatReplaceAllType, _with: str, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, type: TableWidgetTextFormatReplaceAllType, _with: str, **kwargs): | |
| def __init__(self, type: TableWidgetTextFormatReplaceAllType, _with: str, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3069
branch
3 times, most recently
from
635c999
to
95a9cd3
Compare
nkzou
approved these changes
Sep 9, 2024
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3069
branch
from
95a9cd3
to
7bf392d
Compare
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3069
branch
from
7bf392d
to
5999cad
Compare
HantingZhang2
approved these changes
Sep 13, 2024
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3069
branch
from
5999cad
to
aff8ee0
Compare
api-clients-generation-pipeline
bot
changed the title
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3069
branch
from
aff8ee0
to
b4d4f3b
Compare
api-clients-generation-pipeline
bot
deleted the
datadog-api-spec/generated/3069
branch
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
…hboards (#2147) Co-authored-by: ci.datadog-api-spec <[email protected]> 06852c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#3069
Test branch datadog-api-spec/test/hyung.lee/payp-27