Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dateToRFC3339String parsing #1201

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Fix dateToRFC3339String parsing #1201

merged 3 commits into from
Jun 21, 2023

Conversation

therve
Copy link
Contributor

@therve therve commented Jun 21, 2023

We can't use getTimezoneOffset as it's a local value independent of the Date object passed.

Fixes #1200

@therve
Fix dateToRFC3339String parsing
410ea83 
We can't use `getTimezoneOffset` as it's a local value independent of
the Date object passed.

Fixes #1200
@therve therve requested a review from a team as a code owner June 21, 2023 07:55
@therve therve merged commit 1a2c6cc into master Jun 21, 2023
@therve therve deleted the therve/fix-date-parsing branch June 21, 2023 21:46
github-actions bot pushed a commit that referenced this pull request Jun 21, 2023
@therve
Fix dateToRFC3339String parsing (#1201)
d95acea 
* Fix dateToRFC3339String parsing

We can't use `getTimezoneOffset` as it's a local value independent of
the Date object passed.

Fixes #1200

* Template 1a2c6cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarimo skarimo skarimo approved these changes

Assignees
No one assigned
Labels
changelog/Fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dateToRFC3339String produces invalid dates
2 participants
@therve @skarimo