Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in deserialization errors #836

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Conversation

therve
Copy link
Contributor

@therve therve commented Sep 13, 2022

If the error schema doesn't match, it swallows the server exception which is very unhelpful. Catch potential errors and raise with the original body instead.

If the error schema doesn't match, it swallows the server exception
which is very unhelpful. Catch potential errors and raise with the
original body instead.
@therve therve requested a review from a team as a code owner September 13, 2022 07:21
@therve therve merged commit bd612ac into master Sep 14, 2022
@therve therve deleted the therve/deserialisation-errors branch September 14, 2022 10:13
github-actions bot pushed a commit that referenced this pull request Sep 14, 2022
If the error schema doesn't match, it swallows the server exception
which is very unhelpful. Catch potential errors and raise with the
original body instead. bd612ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants