Remove node specific checks and unblock running in workers #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarimo
changed the title
skarimo
changed the title
therve
approved these changes
Nov 7, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
* fix node env checking * remove node specific calls * only set accept-encoding in non browser envs * lint * remove os package usage 16a5b50
vvo
added a commit
to vvo/datadog-api-client-typescript
that referenced
this pull request
Nov 29, 2022
Before this commit, datadog-api-client was not compatible with Vercel's Edge Runtime (https://edge-runtime.vercel.app/). 1. While `process` exists, process.release doesn't. So changes from DataDog#899 were not complete 2. I added a few more code to really identify Edge Runtime as a different Node.js (server) environment that can use fetch Let me know if that's OK.
vvo
added a commit
to vvo/datadog-api-client-typescript
that referenced
this pull request
Nov 29, 2022
Before this commit, datadog-api-client was not compatible with Vercel's Edge Runtime (https://edge-runtime.vercel.app/). 1. While `process` exists, process.release doesn't. So changes from DataDog#899 were not complete 2. I added a few more code to really identify Edge Runtime as a different Node.js (server) environment that can use fetch Let me know if that's OK.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #658
Runtimes where
cross-fetchpackage is not compatible due to the following issue lquixada/cross-fetch#78 will need to implement their own HttpLibrary implementation. See example implementation with proxy usage here: https://github.com/DataDog/datadog-api-client-typescript#configure-proxy