Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dogstatsd] Add support for including container id #172

Closed
wants to merge 1 commit into from

Conversation

xornivore
Copy link

  • Adds DD_ENTITY_TYPE to enable collecting container_id://.. entity ID automatically.
  • Code for the cgroup parsing is essentially the same as in dd-trace-go.

- Adds `DD_ENTITY_TYPE` to enable collecting `container_id://..` entity ID automatically.
@xornivore xornivore requested a review from a team October 26, 2020 22:52
@xornivore xornivore marked this pull request as ready for review October 28, 2020 21:54
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for containers, let's get 👀 from agent core!

@hush-hush
Copy link
Member

Closing this PR, it was superseded by #250

@hush-hush hush-hush closed this Feb 21, 2022
@hush-hush hush-hush deleted the xornivore/dogstatsd-container-id-entity branch February 21, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants