DefaultAggregationFlushInterval: 3s -> 2s; reduce sampling aliasing #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending a count metric that increments at a constant 1000/sec, client-side aggregation causes it to appear noisy, reporting values of 900, 900, 1200 instead of the constant 1000/sec. This appears to be mostly caused by mismatched reporting intervals. The client-side aggregation is reporting every 3 seconds, while the agent is reporting every 10 seconds. This means in each agent bucket, the values are: 9000, 9000, 12000, ... . Setting the flush interval to 2 seconds corrects this issue.
|
I spent some time trying to figure out if I could add a test for this, but I'm not sure it is worth the effort. I'm happy to try if you have suggestions for how to do it. |
hush-hush
approved these changes
May 28, 2021
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending a count metric that increments at a constant 1000/sec,
client-side aggregation causes it to appear noisy, reporting values
of 900, 900, 1200 instead of the constant 1000/sec. This appears to
be mostly caused by mismatched reporting intervals. The client-side
aggregation is reporting every 3 seconds, while the agent is
reporting every 10 seconds. This means in each agent bucket, the
values are: 9000, 9000, 12000, ... . Setting the flush interval to
2 seconds corrects this issue.