-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statsd: set client_transport properly #290
statsd: set client_transport properly #290
Conversation
|
It's not really possible to do (1) because the tags are defined before the writer guesses the socket type. The current implementation seems to be backward compatible with other clients and previous behavior in the sense that nothing will change for existing configurations (but more explicit configuration will allow us to have more explicit tagging). In the long run I think it's a good incentive to have people move to |
Ok I addressed the comment, and now unix datagram is reported as |
This propagates the transport from the sender (and writer) to the telemetry client directly.
This introduces a new
Transport
interface withgetTransportName()
and teaches the telemetry client to read this and refresh its tags when necessary.The result will be that:
will use
client_transport:udsunless it connects to a UDS stream socket (and then switch to
client_transport:uds-stream`)will always directly use
client_transport:uds-stream`