add datadog.parse_record_headers property #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remeh
reviewed
May 15, 2024
There was a problem hiding this comment.
Hey @jm1221d, thanks for the contribution!
I left a few comments and I also have a separate question on the OpenTelemetry implementation you're referring to: is this implementation also adding these headers in a JSON or are they sent differently?
src/main/java/com/datadoghq/connect/logs/sink/DatadogLogsApiWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/datadoghq/connect/logs/sink/DatadogLogsApiWriter.java
Outdated
Show resolved
Hide resolved
|
Hi @remeh , thanks for looking at the PR! Currently, the OpenTelemetry implementation adds a header called traceparent (or other headers if enabled -> b3), and the value format is described here: https://www.w3.org/TR/trace-context/ |
urseberry
reviewed
May 15, 2024
urseberry
approved these changes
May 17, 2024
remeh
approved these changes
May 22, 2024
|
Thanks for the contribution @jm1221d. I'll try to have a new release v1.3.0 shipped this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a property
datadog.parse_record_headersto the connector configuration that enables parsing the Kafka Record Headers and sending them to DataDog. The attribute would be calledkafkaheaders.Motivation
Currently, Kafka Record Headers are not sent to DataDog. OpenTelemetry injects a record header, called traceparent, to all kafka records. This change would enable us to correlate all records that we received in DataDog by the traceparent record header key or any other record header key.
Additional Notes
Additionally, we could add another property that would explicitly contain the header keys that the user wants to parse and send to DataDog.