Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aj/honor both proxies in order #410

Merged
merged 8 commits into from
Oct 23, 2024
Merged

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Oct 11, 2024

We need to honor DD_PROXY_HTTPS over HTTPS_PROXY for compatibility with the main agent.
Tested and verified manually.
Metrics with DataDog/libdatadog#673:
metrics
Traces with DataDog/libdatadog#673:
traces
Logs with this PR:
logs

@astuyve astuyve requested a review from a team as a code owner October 11, 2024 17:21
@astuyve astuyve merged commit 527db82 into main Oct 23, 2024
24 checks passed
@astuyve astuyve deleted the aj/honor-both-proxies-in-order branch October 23, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants