Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd-trace cleanup #96

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

amancevice
Copy link
Contributor

What does this PR do?

  • upgrade deprecated GitHub action versions for actions/checkout and actions/setup-node
  • add default task for Rakefile (:test task)
  • update gemspec to use datadog gem ~> 2.0
  • update logging references to "dd-trace" to "datadog"
  • remove :span_type from tracer options
  • set log level on init instead of on-demand

Motivation

current version isn't compatible with datadog gem (v2)

Testing Guidelines

bundle exec rake test

Additional Notes

N/A

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

set log level from DD_LOG_LEVEL on init
use $stderr instead of $stdout
upgrade actions/checkout
upgrade actions/setup-node
use datadog instead
add default task (:test)
@amancevice amancevice requested a review from a team as a code owner September 22, 2024 17:28
@duncanista duncanista self-assigned this Sep 23, 2024
@duncanista duncanista mentioned this pull request Oct 11, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants