Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Bump golangci-lint to 1.61.0 and devcontainer to Go 1.23 #1409

Closed
wants to merge 2 commits into from

Conversation

tbavelier
Copy link
Member

@tbavelier tbavelier commented Sep 12, 2024

What does this PR do?

Motivation

Additional Notes

With this golangci-lint bump comes a warning on a deprecated linter :

WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.

Describe your test plan

  • Run make lint without errors
  • Run make build without errors

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.40%. Comparing base (6d4bbd9) to head (8d65acc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1409   +/-   ##
=======================================
  Coverage   47.40%   47.40%           
=======================================
  Files         223      223           
  Lines       19244    19244           
=======================================
  Hits         9123     9123           
  Misses       9635     9635           
  Partials      486      486           
Flag Coverage Δ
unittests 47.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4bbd9...8d65acc. Read the comment docs.

@tbavelier tbavelier marked this pull request as ready for review September 12, 2024 11:49
@tbavelier tbavelier requested review from a team as code owners September 12, 2024 11:49
@tbavelier
Copy link
Member Author

Closing, dev-1.22 dev container Go version is now 1.22.7 (https://github.com/devcontainers/images/pull/1206/files#diff-fab8c9742fffbe0043947c8a57c9981ed806fad317265f61c2a473068c5b46ac), fixing the original issue, while the golangci-lint bump was solely required due to 1.23 incompatibility:

╰─❯ docker run --rm -it mcr.microsoft.com/devcontainers/go:dev-1.22 go version
go version go1.22.7 linux/arm64

@tbavelier tbavelier closed this Oct 7, 2024
@tbavelier tbavelier deleted the tbavelier/bump_devcontainer_andgolang_ci_lint branch October 7, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants