Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support pattern /aws/vendedlogs for API GATEWAY logs groups #616

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cunymatthieu
Copy link

@cunymatthieu cunymatthieu commented Oct 24, 2022

What does this PR do?

Correctly categorize log groups starting with /aws/vendedlogs/* for AWS API GATEWAY.
Datadog log forwarder should send the service name with apigateway instead of cloudwatch.

Motivation

Avoid touching the size limit of the log group resource policy

Log group resource policy size limit considerations

These services must list each log group that they're sending logs to in the resource policy, and CloudWatch Logs resource policies are limited to 5120 characters. A service that sends logs to a large number of log groups may run into this limit.

To mitigate this, CloudWatch Logs monitors the size of resource policies used by the service that is sending logs, and when it detects that a policy approaches the size limit of 5120 characters, CloudWatch Logs automatically enables /aws/vendedlogs/* in the resource policy for that service. You can then start using log groups with names that start with /aws/vendedlogs/ as the destinations for logs from these services.

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@cunymatthieu cunymatthieu force-pushed the feat/update-find-cloudwatch-source branch from 5c09962 to 682adf4 Compare October 24, 2022 14:08
@cunymatthieu cunymatthieu force-pushed the feat/update-find-cloudwatch-source branch from 3efeb46 to f50f42a Compare October 27, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant